From 8356b6c75092fdcba61c21a9b2c2292c435c07de Mon Sep 17 00:00:00 2001 From: liquidev Date: Sun, 8 Sep 2024 12:12:33 +0200 Subject: [PATCH] fix compilation errors not setting error flag in brush preview --- static/brush-preview.js | 12 ++++++++++-- static/index.js | 5 ++++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/static/brush-preview.js b/static/brush-preview.js index 46624ef..cfba2cb 100644 --- a/static/brush-preview.js +++ b/static/brush-preview.js @@ -45,13 +45,21 @@ export class BrushPreview extends HTMLElement { } renderBrush(haku) { - this.classList.remove("error"); + this.unsetErrorFlag(); let result = this.#renderBrushInner(haku); if (result.status == "error") { - this.classList.add("error"); + this.setErrorFlag(); } return result; } + + unsetErrorFlag() { + this.classList.remove("error"); + } + + setErrorFlag() { + this.classList.add("error"); + } } customElements.define("rkgk-brush-preview", BrushPreview); diff --git a/static/index.js b/static/index.js index 19cc3bb..9fa5ecb 100644 --- a/static/index.js +++ b/static/index.js @@ -265,7 +265,10 @@ function readUrl(urlString) { let compileResult = currentUser.setBrush(brushEditor.code); brushEditor.renderHakuResult("Compilation", compileResult); - if (compileResult.status != "ok") return; + if (compileResult.status != "ok") { + brushPreview.setErrorFlag(); + return; + } let previewResult = brushPreview.renderBrush(currentUser.haku); if (previewResult.status == "error") {