Compiling brush doesn't seem to finish correctly sometimes, which causes loss of data #81

New issue

Open

opened 2024-09-01 23:12:38 +02:00 by liquidev · 2 comments

liquidev commented

2024-09-01 23:12:38 +02:00

(Migrated from github.com)

Sometimes it seems like the client state can get desynced (server render thread dies due to a panic?) and then the server starts dropping all requests for drawing the brush.

These panics should never happen of course, but we need better logging first to determine the exact cause.

Sometimes it seems like the client state can get desynced (server render thread dies due to a panic?) and then the server starts dropping all requests for drawing the brush. These panics should never happen of course, but we need better logging first to determine the exact cause.

liquidev commented

2024-09-02 21:54:41 +02:00

(Migrated from github.com)

I fixed the panic, but what should probably happen with any panics on the render thread is that we should catch_unwind them and then kill the connection.

I fixed the panic, but what should probably happen with _any_ panics on the render thread is that we should `catch_unwind` them and then kill the connection.

liquidev commented

2024-09-03 18:12:04 +02:00

(Migrated from github.com)

It seems like tokio channels are not catch_unwind-safe, so we can't easily catch_unwind the whole render thread and kill the connection if something wrong happens, as far as I reckon.

I'm bumping this down in the backlog becasue the parser panic is fixed, and I have no idea how to kill the connection if the render thread dies :/

It seems like tokio channels are not `catch_unwind`-safe, so we can't easily `catch_unwind` the whole render thread and kill the connection if something wrong happens, as far as I reckon. I'm bumping this down in the backlog becasue the parser panic is fixed, and I have no idea how to kill the connection if the render thread dies :/